Any asset fee feature #10
Conversation
| void ClearPrioritisation(const uint256& hash); | ||
|
|
||
| /** Recompute valuation of all transaction fees, called whenever exchange rates have been updated. */ | ||
| void RecomputeFees(); |
There was a problem hiding this comment.
Do we need that EXCLUSIVE_LOCKS_REQUIRED here? Why or why not?
There was a problem hiding this comment.
RecomputeFees() takes the lock, and EXCLUSIVE_LOCKS_REQUIRED means that the lock must already be held. So we don't need it here.
|
|
||
| CAsset feeAsset; | ||
| if (g_con_any_asset_fees) { | ||
| feeAsset = fee_map.begin()->first; |
There was a problem hiding this comment.
What happens if there's zero, or two or more?
There was a problem hiding this comment.
I mean, at least explain it in a comment.
There was a problem hiding this comment.
Added a comment and some TODOs in: 65ffeb0
The short answer is that there should never be more than one, and since ConstructTransaction enforces this, it's loosely correct by construction. If we want a stronger guarantee, we might want to add a check in consensus.
| self.node1_nonct_address = self.nodes[1].getaddressinfo(self.node1_address)["unconfidential"] | ||
|
|
||
| self.nodes[0].setfeeexchangerates({ "gasset": 100000000, self.asset: 100000000 }) | ||
| self.nodes[1].setfeeexchangerates({ "gasset": 100000000, self.asset: 100000000 }) |
| } | ||
| EnsureAnyMemPool(request.context).RecomputeFees(); | ||
| return NullUniValue; | ||
| }, |
There was a problem hiding this comment.
I suppose this is good enough for now, but then open a followup issue so that:
- the load-from-file and load-from-rpc share the same code
- that code validates the entire data structure before it is used, so the global exchangeRateMap is not left in unusable state if something goes wrong.
- maybe save the json to a temporary file, fdatasync, then atomically replace the startup file, if things go right.
This covers the first milestone of the No Coin project, modifying the on-chain protocol to support fee payment in any asset. It also includes the necessary changes to the mempool to allow block signers to valuate assets at their desired exchange rates, and introduces two new exchangerate RPCs for getting and setting those rates.
Cliff notes:
g_con_any_asset_feesfor enabling No Coin featurecreaterawtransaction,fundrawtransaction, andsendtoaddress)getfeeexchangeratesandsetfeeexchangerates)gettransactionandlisttransactions)